This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Revert "revert enabling authority discovery by default (#1532)"#1807
Merged
1 commit merged intomasterfrom Oct 13, 2020
Merged
Conversation
bkchr
approved these changes
Oct 12, 2020
tomaka
approved these changes
Oct 13, 2020
Contributor
|
bot merge |
|
Trying merge. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 671cc75.
The authority discovery module was initially enabled by default on validator and sentry nodes with commit bc6e1e7. This change was later on reverted in 671cc75. With this commit the authority discovery module is again enabled by default.
With libp2p/rust-libp2p#1698 the amount of file descriptors needed for the authority discovery Kademlia DHT activities has been drastically reduced. With paritytech/substrate#7018 lookups are spread out instead of done all at once removing any spikes in number of file descriptors, network traffic or CPU usage.
After a testing phase on a couple of our Kusama validator and sentry nodes the authority discovery module is now enabled on the majority of Parity Kusama nodes. For details see either paritytech/substrate#7018 (comment) or consult the corresponding authority discovery Grafana dashboard.
Closes #1544.
Release note suggestion: